Example of a simple working FTP.List code

Asmoro · Dec 18, 2011

Hi All,

I searched and tried several FTP.List examples and how to's
from everyone here on this forum.
It didn't work for me though, unfortunately.

The only thing that worked a bit is an empty imagefile??
If someone knows the issue, I will gladly here from you.

Thanks for now.

Erel · Dec 18, 2011

Which error did you get?
Did you check the logs?

Are you using a real device? The emulator doesn't work properly with FTP.
Have you tried setting FTP.PassiveMode to True?

Asmoro · Dec 19, 2011

Hi Erel,

As a matter of fact, none of these I'd got.

Yes, most of the time I use a real device for testing.

No, my Filezilla client is in automode for active or passive
and in Binary, so no issue with these.
The proof was that I succeeded to download a specific
imagefile from my server to my phone.

vb1992 · Dec 19, 2011

Dim FTP As FTP

FTP.Initialize("FTP", "FTP.secureftp-test.com", 21, "test", "test")

FTP.List("/")

Asmoro · Dec 19, 2011

Hi vb1992,

I tried that already, didn't work.

I also tried with FTP.List("public_html/Test2/") as a serverpath and worked, but didn't go the a specific folder on the sdcard. It went on the sdcard instead.

This is what I have so far:

B4X:

Sub btTest_Click    'ListFiles (Dir As String) As List
   ImageFolder2 = File.DirRootExternal & "/Test1/"
   Files.Initialize
   Files = File.ListFiles(ImageFolder2)
   Files.SortCaseInsensitive(True)
   
   FTP.List("public_html/Test2/")   
   FTP.PassiveMode = True
End Sub
Sub   FTP_DownloadProgress (ServerPath As String, TotalDownloaded As Long, Total As Long)
   Dim s As String
   s = "public_html/Test2/" & Round(TotalDownloaded / 1000) & "KB"
   If Total > 0 Then s = s & " out of " & Round(Total / 1000) & "KB"
   Log(s)
End Sub

Sub   FTP_DownloadCompleted (ServerPath As String, Success As Boolean)
   Log(ServerPath & ", Success=" & Success)
   If Success = False Then Log(LastException.Message)
   
End Sub
Sub FTP_ListCompleted (ServerPath As String, Success As Boolean, Folders() As FTPEntry, Files() As FTPEntry)
       Log(ServerPath)
      If Success = False Then
           Log(LastException)
      Else
          For i = 0 To Folders.Length - 1
               Log(Folders(i).Name)
           Next
           For i = 0 To Files.Length - 1
               Log(Files(i).Name & ", " & Files(i).Size & ", " & DateTime.Date(Files(i).Timestamp))
           Next
       End If
End Sub

How did you manage with the "empty" variable on the: "

B4X:

Sub FTP_ListCompleted (ServerPath As String, Success As Boolean, Folders() As FTPEntry, Files() As FTPEntry)

"

After some changes in the code, nothing worked anymore.

vb1992 · Dec 19, 2011

Tips:

1) Add latest NET Library

2) Make Sure you don't have other FTP test apps running (Reboot phone if needed)

B4X:

'Activity module
Sub Process_Globals
   'These global variables will be declared once when the application starts.
   'These variables can be accessed from all modules.
   
   
   
   Dim FTP As FTP
   
   
   
End Sub

Sub Globals
   'These global variables will be redeclared each time the activity is created.
   'These variables can only be accessed from this module.

End Sub

Sub Activity_Create(FirstTime As Boolean)
 
 Activity.Title= "Use the Menu to List the Files"
 Activity.AddMenuItem("LIST FILES","menuLIST")
 
 
End Sub

Sub Activity_Resume

If FTP.IsInitialized Then FTP.closenow


  FTP.Initialize("FTP", "FTP.secureftp-test.com", 21, "test", "test")
End Sub



Sub Activity_Pause (UserClosed As Boolean)
FTP.Close
End Sub



Sub menuLIST_Click
ToastMessageShow("Checking for FTP List now",False)
FTP.PassiveMode = True

   FTP.List("./")
End Sub
 
   Sub FTP_ListCompleted (ServerPath As String, Success As Boolean, Folders() As FTPEntry, Files() As FTPEntry)
       Log(ServerPath)
       If Success = False Then
           Log(LastException)
       Else
           For i = 0 To Folders.Length - 1
         ToastMessageShow(Folders(i).Name,False)
            Log(Folders(i).Name)
           Next
           For i = 0 To Files.Length - 1
               Log(Files(i).Name & ", " & Files(i).Size & ", " & DateTime.Date(Files(i).Timestamp))
               ToastMessageShow(Files(i).Name & ", " & Files(i).Size & ", " & DateTime.Date(Files(i).Timestamp),False)
            
        Next
       End If
   End Sub

Asmoro · Dec 19, 2011

Hi vb1992,

Thanks for your input.

I did all your tips but I still get some error that I'd mentioned it befor:

Compiling code. Error
Error parsing program.
Error description: Parameter name cannot hide global variable name.
Occurred on line: 113
Sub FTP_ListCompleted (ServerPath As String, Success As Boolean, Folders() As FTPEntry, Files() As FTPEntry)

Any idea's??

vb1992 · Dec 19, 2011

Hi, you will have to zip a complete project up
in order to test it

Use the file/export zip
feature

Asmoro · Dec 20, 2011

Well, I made a test project regarding ftp.list downloading imagefiles as been asked.

It works (not perfect though) according to the logs confirmation, but no imagefiles
on my sdcard folder "File.DirRootExternal & "/Test/" yet.

So, I hope someone knows the answer, cause I'm already fed up with this. :sign0148:

note: to get this project working (attached), use your own ftp location etc
and create some folder in your sdcard. That's it.

vb1992 · Dec 20, 2011

This will download the file correctly
I named the file: 999999999999.zip
because it's a lot easier to find when your searching around
your android device with a file manger

B4X:

'Activity module
Sub Process_Globals
   'These global variables will be declared once when the application starts.
   'These variables can be accessed from all modules.
   
   Dim FTP As FTP

End Sub

Sub Globals
   'These global variables will be redeclared each time the activity is created.
   'These variables can only be accessed from this module.

   
   Dim btn_download As Button
   Dim btn_list As Button
   Dim btn_Upload As Button
   Dim Button1 As Button
   Dim Button2 As Button
End Sub

Sub Activity_Create(FirstTime As Boolean)

   Activity.LoadLayout("Main")
   
   
End Sub

Sub Activity_Resume
 FTP.Initialize("FTP", "FTP.secureftp-test.com", 21, "test", "test")
End Sub

Sub Activity_Pause (UserClosed As Boolean)

End Sub

   

Sub FTP_DownloadProgress (ServerPath As String, TotalDownloaded As Long, Total As Long)
Dim s As String
s = "Downloaded " & Round(TotalDownloaded / 1000) & "KB"
If Total > 0 Then s = s & " out of " & Round(Total / 1000) & "KB"
Log(s)
End Sub

Sub FTP_DownloadCompleted (ServerPath As String, Success As Boolean)
Log(ServerPath & ", Success=" & Success)
If Success = False Then Log(LastException.Message)
End Sub



Sub btn_download_Click
   FTP.PassiveMode = True
    msgbox("File will be stored in: " &  File.DirRootExternal,"")
   FTP.DownloadFile("hamlet.zip", False, File.DirRootExternal, "999999999999.zip")
      
End Sub

Sub FTP_ListCompleted (ServerPath As String, Success As Boolean, Folders() As FTPEntry, Files() As FTPEntry)

   If Success == False Then
      Log(LastException.Message)
   Else
      For i = 0 To Files.Length - 1
         Log(Files(i).Name)
      Next
      For i = 0 To Folders.Length - 1
         Log(Folders(i).Name)
      Next
   End If
End Sub

Asmoro · Dec 20, 2011

Thanks again vb,

One question though , according to your code for downloading, does it mean that I have to change this:

B4X:

FTP.DownloadFile("hamlet.zip", False, File.DirRootExternal, "999999999999.zip")

to:

B4X:

FTP.DownloadFile(".jpg", False, File.DirRootExternal, ".jpg")

getting from a specific folder all the .jpg imagefiles from the server ?

Cause that's what I'm trying to achieve here.

btw. I'm not testing your code while writing this.

vb1992 · Dec 20, 2011

Test with this, and it will work, then modify it
for your own server/project and change .xml to .jpg

B4X:

Sub Process_Globals
 
    Dim FTP As FTP

End Sub



Sub Globals
    
    Dim btn_download As Button
    Dim btn_list As Button
    Dim btn_Upload As Button
    Dim Button1 As Button
    Dim Button2 As Button

End Sub

Sub Activity_Create(FirstTime As Boolean)
 
 Activity.Title= "Use the Menu to Download the JPG Files"
 Activity.AddMenuItem("Download JPG Files","menuLIST")
 
 
End Sub

Sub Activity_Resume

If FTP.IsInitialized Then FTP.closenow
  FTP.Initialize("FTP", "FTP.secureftp-test.com", 21, "test", "test")
  
End Sub



Sub Activity_Pause (UserClosed As Boolean)
FTP.Close
End Sub



Sub menuLIST_Click


    Msgbox("File will be stored in: " &  File.DirRootExternal,"")
   
ToastMessageShow("Checking for FTP List now",False)
FTP.PassiveMode = True

   FTP.List("./")
   
End Sub
 
   Sub FTP_ListCompleted (ServerPath As String, Success As Boolean, Folders() As FTPEntry, Files() As FTPEntry)
       Log(ServerPath)
       If Success = False Then
           Log(LastException)
       Else
           For i = 0 To Folders.Length - 1
         ToastMessageShow(Folders(i).Name,False)
            Log(Folders(i).Name)
           Next
           For i = 0 To Files.Length - 1
               Log(Files(i).Name & ", " & Files(i).Size & ", " & DateTime.Date(Files(i).Timestamp))
               ToastMessageShow(Files(i).Name & ", " & Files(i).Size & ", " & DateTime.Date(Files(i).Timestamp),False)
         
            If Files(i).Name.EndsWith(".xml") Then FTP.DownloadFile(Files(i).Name, False, File.DirRootExternal, Files(i).Name)
        
      Next
       End If
   End Sub
   
   
   
   
   
 
   

Sub FTP_DownloadProgress (ServerPath As String, TotalDownloaded As Long, Total As Long)
Dim s As String
s = "Downloaded " & Round(TotalDownloaded / 1000) & "KB"
If Total > 0 Then s = s & " out of " & Round(Total / 1000) & "KB"
Log(s)
End Sub

Sub FTP_DownloadCompleted (ServerPath As String, Success As Boolean)
Log(ServerPath & ", Success=" & Success)
If Success = False Then Log(LastException.Message)
End Sub

Asmoro · Dec 21, 2011

Hi vb1992,

I implemented your code for testing.
It worked well but again an empty imagefile
on my sdcard.

Underneath is the log output of the error:

Installing file.
PackageAdded: package:B4A.FTP
** Activity (main) Create, isFirst = true **
** Activity (main) Resume **
public_html/test/
.
..
Morgan-EvaGT_2012.jpg, 50358, 12/20/2011
caterham.jpg, 94549, 12/20/2011
mercedes CLife.jpg, 41679, 12/20/2011
public_html/test/, Success=false
java.lang.RuntimeException: Error retrieving file.
550 I can only retrieve regular files

public_html/test/, Success=false
java.lang.RuntimeException: Error retrieving file.
550 I can only retrieve regular files

public_html/test/, Success=false
java.lang.RuntimeException: Error retrieving file.
550 I can only retrieve regular files

** Activity (main) Pause, UserClosed = true **

After that I was searching on the internet if it has something
to do with the server config.
On the other hand it was ok with the FTP.DownloadFile code
retrieving a specific imagefile.

So I'm a little bit confused.

Could it be with the code what you had made?
I also changed the .xml to .jpg.

vb1992 · Dec 21, 2011

Let's start with the basics, let's get the example code to work as is, since I know that works

a) Did you test the code as is, and are you able to get and write
the xml files to your sd card?

b) could be with writing to your sd card?
see: writing-external-storage-sd-card.html#post52341

Asmoro · Dec 21, 2011

Well,

It seems that has nothing to do with your code or mine.
Probably yours working allright, so my deep :sign0188:

It has to do with how Filezilla or any kind of ftp server works
with retrieving/sending multiple files.

I explained at the Filezilla forum what the problem was, and
this is the answer in return:

FTP can only retrieve or send single files with each RETR/STOR command. Usually works like this:

1. The client changes into the directory using the CWD command, then checks if the directory change was successful (PWD).
2. The client retrieves a listing of all objects in that directory (using LIST, or the more preferred MLSD, if supported).
3. The client then must parse the received listing for the files it desires and put them into a sort of queue.
4. Then it generates one RETR/STOR command per file and processes them in a batch style (either immediately or after having parsed all directories).
5. For recursivity, 1-4 must be repeated for each directory in the tree.

:sign0148:

Erel did post something at the forum about FTP.Send Command(pwd,...)
Maybe that's the way how has to be done.

If you know it, share it.:sign0163:

vb1992 · Dec 21, 2011

I believe that the code does/will work for you

You can add

B4X:

     If Files(i).Name.EndsWith(".jpg") Then 

        FTP.SendCommand("binary")

        FTP.DownloadFile(Files(i).Name, False, File.DirRootExternal, Files(i).Name)

end if

Since you said the jpg file was empty

vb1992 · Dec 21, 2011

try this example, you can modify the globals to your server

Asmoro · Dec 21, 2011

vb1992 said:
I believe that the code does/will work for you

You can add

B4X:

If Files(i).Name.EndsWith(".jpg") Then FTP.SendCommand("binary") FTP.DownloadFile(Files(i).Name, False, File.DirRootExternal, Files(i).Name) end if

Since you said the jpg file was empty

Sorry, didn't work.

I'm gonna fetch your example and will let you know a.s.a.p.

Asmoro · Dec 22, 2011

Hi vb1992,

I tried your example and get the same problem.
(empty image files and log errors)

After that I Googled a little and saw a Linux command ftp like:

ftp> mget *.jpg

With mget you can download multiple images. This command downloads all files that end with ".jpg".

And typing this in FTP.SendCommand("mget", "*.jpg") --> correct me if
this is a wrong syntax/code.

vb1992 · Dec 22, 2011

This seems to be something with your ftp server configuration.
I would suggest you trying some other FTP Server software.

I don't think changing a command is going to solve your problem
since you already have some valid working code

The example project works, and I tested it both downloading
xml files, and also a binary / zip file

Example of a simple working FTP.List code

Active Member

B4X founder

Active Member

Well-Known Member

Active Member

Well-Known Member

Active Member

Well-Known Member

Active Member

Attachments

Well-Known Member

Active Member

Well-Known Member

Active Member

Well-Known Member

Active Member

Well-Known Member

Well-Known Member

Attachments

Active Member

Active Member

Well-Known Member