Android Question Confirmation says ok but row not deleted. OK on s21 phone external db not on s25 Dir.internal

garkin said:

Sub DeleteEntry
Private Query As String
'''.........................................
SQL1.Initialize(File.DirInternal, "PHockey.db", True)
'''.........................................
Private Answ As Int
'ask the user for confirmation
Answ = Msgbox2("Do you really want to delete " & edtName.Text, "Delete entry", "Yes", "", "No", Null)
If Answ = DialogResponse.POSITIVE Then 'if yes, delete the entry
'''.........................................


Query = "DELETE FROM PHockey WHERE ID = " & Main.IDList.Get(Main.CurrentIndex)
Main.SQL1.ExecNonQuery(Query) 'delete the entry
Main.IDList.RemoveAt(Main.CurrentIndex) 'remove the ID from the list
If Main.CurrentIndex = Main.RowNumber - 1 Then 'if the current index is the last one
Main.CurrentIndex = Main.CurrentIndex - 1 'decrement it by 1
End If
Main.RowNumber = Main.RowNumber - 1 'decrement the row count by 1
ShowEntry(Main.CurrentIndex) 'show the next entry
ToastMessageShow("Entry deleted", False) 'confirmation for the user
ShowButtons
End If
End Sub

Click to expand...

Dim Query as string

Query="DELETE FROM PHockey WHERE ID = ?"
Main.SQL.ExecuteNonQuery2(Query,ID)

dim Qty as int

'Let's check if the record exists
Query="Select count(ID) as Qty FROM PHockey WHERE ID = ?"

Qty=Main.SQL1.ExecQuerySingleResult2(Query,ID)

If Qty>0 then
    Query="DELETE FROM PHockey WHERE ID = ?"
    Main.SQL.ExecuteNonQuery2(Query,ID)
End If

Alex_197 said:

First of all use parameterized query

B4X:

Dim Query as string

Query="DELETE FROM PHockey WHERE ID = ?"
Main.SQL.ExecuteNonQuery2(Query,ID)

But I would do like this

B4X:

dim Qty as int

'Let's check if the record exists
Query="Select count(ID) as Qty FROM PHockey WHERE ID = ?"

Qty=Main.SQL1.ExecQuerySingleResult2(Query,ID)

If Qty>0 then
    Query="DELETE FROM PHockey WHERE ID = ?"
    Main.SQL.ExecuteNonQuery2(Query,ID)
End If

Click to expand...

garkin said:

Thanks Alex but I am getting a compiling error with the word ID

Click to expand...

Dim ID,Qty As int

ID=Main.IDList.Get(Main.CurrentIndex)

'Let's check if the record exists
Query="Select count(ID) as Qty FROM PHockey WHERE ID = ?"

Qty=Main.SQL1.ExecQuerySingleResult2(Query,ID)

If Qty>0 then
    Query="DELETE FROM PHockey WHERE ID = ?"
    Main.SQL.ExecuteNonQuery2(Query,ID)
End If

garkin said:

Thanks Brian. Still have the problem. I'm not sure why the code i showed does not work with my S25+ phone. It has been ok on my S21 and Tab8.
Both those devices used Dir.External for the hockey db. S25 and api35 want Dir.internal so that is the only difference in the coding

Click to expand...