Android Question CustomListview row height

Erel

B4X founder

Staff member

Licensed User

Longtime User

• Dec 17, 2017

• #2

Do you want the row height to be the same as the activity height?

Where is the code that adds the items?

 

Upvote 0

T

taylorw

Active Member

Licensed User

• Dec 18, 2017

• #3

Hi Erel, no same as the activity height, is if in different device the row height are not same, you can see the first post.
The "false.png" the row height too height, can make it look like "True.png"?

B4X:

Dim RowHeight As Double
RowHeight = ((1740 - 100%y)/8.8) + 120

B4X:

Listview_Car.Add(CreateListItem(M.Get("Car"),Listview_Car.AsView.Width,RowHeight),RowHeight,M.Get("Car"))

B4X:

Sub CreateListItem(Car As String, Width As Int, Height As Int) As Panel
    Dim p As Panel
    
    p.Initialize("")
    Activity.AddView(p, 0, 0, Width, Height)
    p.LoadLayout("Custom_Car_List")
    p.RemoveView
    'label1 and button1 will point to the last added views.
    lblCar.Text = Car
    Line.Top = Height - 1
    Return p
    
    
End Sub

 

Upvote 0

klaus

Expert

Licensed User

Longtime User

• Dec 18, 2017

• #4

This looks wrong to me:
RowHeight = ((1740 - 100%y)/8.8) + 120
What is 1740 ?
You must use dip values and not pure pixels!
RowHeight = ((1740dip - 100%y)/8.8) + 120dip
If 1740 is the height of a view, you should use viewxxx.Height instead of 1740.

In this line
Listview_Car.Add(CreateListItem(M.Get("Car"),Listview_Car.AsView.Width,RowHeight),RowHeight,M.Get("Car"))
you have one parameter more than in this line !?
Sub CreateListItem(Car As String, Width As Int, Height As Int) As Panel

 

Upvote 0

LucaMs

Expert

Licensed User

Longtime User

• Dec 18, 2017

• #5

klaus said:

- 100%y

Click to expand...

???

 

Upvote 0

klaus

Expert

Licensed User

Longtime User

• Dec 18, 2017

• #6

LucaMs, you are right, i didn’t look deeply enough the equation, I was more concentrated on the dip values.

 

Last edited: Sep 9, 2022

Upvote 0

Erel

B4X founder

Staff member

Licensed User

Longtime User

• Dec 18, 2017

• #7

I don't understand this line:

B4X:

RowHeight = ((1740 - 100%y)/8.8) + 120

Doesn't look correct.

 

Upvote 0

T

taylorw

Active Member

Licensed User

• Dec 19, 2017

• #8

Sorry for late reply, the 1740 is my phone screen Height.
"RowHeight = ((1740 - 100%y)/8.8) + 120" This is some formula to calculate the different device height to get the row need to set how many height.
@Erel , @klaus
Your guys how to set the CustomeListview row height? Can teach me?

 

Upvote 0

Erel

B4X founder

Staff member

Licensed User

Longtime User

• Dec 19, 2017

• #9

This line is incorrect. As Klaus wrote all values must include units.

1. I recommend you to use the latest version of CustomListView: https://www.b4x.com/android/forum/t...listview-cross-platform-customlistview.84501/
2. I still don't understand what the height should be.

 

Upvote 0

klaus

Expert

Licensed User

Longtime User

• Dec 19, 2017

• #10

To give a concrete answer you must give us more information.
What exactly did you want to achieve with your equation?
As an example:
If your device has a screen height of 1740 pixels, then:
1740 - 100&y would be equal to ZERO, therefore Height would be 120 pixels.
Then, if you had a device wih a screen height of 740 pixels
Height would be equal to 233!
So, what exactly do you want to achieve with your equation?
Why do you want to adjust the item height according to the screen height?
It seems that you add just one Label, so could use Listview_Car.AddTextItem, the height is adjusted automatically.

 

Upvote 0

T

taylorw

Active Member

Licensed User

• Dec 19, 2017

• #11

Thanks @Erel,I will read it.

@klaus for this question <So, what exactly do you want to achieve with your equation?>,
I don't want look like thick.


Then this look like thin.



Thanks for your time!Best Regards!

 

Upvote 0

LucaMs

Expert

Licensed User

Longtime User

• Dec 20, 2017

• #12

It depends on what you want to put in a single Item!

If it contains only one label or anyway views on a single line (item, row or call it how you want), you could set the height of the item to 45-50dips.

So, if each item must contain two "rows" of views (labels, edittexts, not big imageview), you could set the height of the item to 90-100dip.

Otherwise you could use something like:

ItemHeight = Max(50dip, CLVHeight / 10)

assumed that on a device 10 items are fine (in this way you would get stretched items, which does not like to everyone )


Useful thread? I opened it and wrote there; so... I don't remember
https://www.b4x.com/android/forum/threads/designer-minimum-layout-height-b4a-5-80.65153/

 

Last edited: Dec 20, 2017

Upvote 0

klaus

Expert

Licensed User

Longtime User

• Dec 21, 2017

• #13

I understant what you want.
My question was about the logic behind your equation.
Why 1740 - 100&y ?
Why /8.8 ?
I would use a fixed height.
Can't you post a small project, so we could see what exactly you have done and how and therefore could give you a concrete advice.

 

Upvote 0

ibs06t

Member

Licensed User

Longtime User

• Sep 8, 2022

• #14

taylorw said:

Thanks @Erel,I will read it.

@klaus for this question <So, what exactly do you want to achieve with your equation?>,
I don't want look like thick.
View attachment 62959

Then this look like thin.

View attachment 62960

Thanks for your time!Best Regards!

Click to expand...

hi
any is this problem solved or not
hot to fix row height in default
anybody help me...

 

Upvote 0

DonManfred

Expert

Licensed User

Longtime User

• Sep 8, 2022

• #15

ibs06t said:

anybody help me...

Click to expand...

Posting to existing threads is a mistake!
You should always create a new thread for your issues.

 

Upvote 0

ibs06t

Member

Licensed User

Longtime User

• Sep 9, 2022

• #16

ok don?

 

Upvote 0