Android Question Table class: "Invalid number of columns"

[mjcoon]

I kept getting such messages, logged or pop-up.

Found code:

    If HeaderTypeFaces.Length <> mNumberOfColumns Then
        ToastMessageShow("Invalid number of columns", False)
        Log("SetHeaderTypeFaces: Invalid number of columns")
        Return
    End If
    
    If HeaderTypeFaces.Length = 1 Then
        cHeaderTypeFace = HeaderTypeFaces(0)
        HeaderMultiTypeFace = False
    Else
    ...

Surely better to check for single typeface first, thus:

    If HeaderTypeFaces.Length = 1 Then
        cHeaderTypeFace = HeaderTypeFaces(0)
        HeaderMultiTypeFace = False
    Else
        If HeaderTypeFaces.Length <> mNumberOfColumns Then
            ToastMessageShow("Invalid number of columns", False)
            Log("SetHeaderTypeFaces: Invalid number of columns")
            Return
        End If
        cHeaderTypeFaces = HeaderTypeFaces
        HeaderMultiTypeFace = True
    End If

There does not seem to be the same problem with cell typefaces because there are both singular and plural subs.

I'm not actually using distinct typefaces, so I would not consider my usage to be a comprehensive test.

Mike.

 

[Lucas Siqueira]

I kept getting such messages, logged or pop-up.

Found code:

    If HeaderTypeFaces.Length <> mNumberOfColumns Then
        ToastMessageShow("Invalid number of columns", False)
        Log("SetHeaderTypeFaces: Invalid number of columns")
        Return
    End If
   
    If HeaderTypeFaces.Length = 1 Then
        cHeaderTypeFace = HeaderTypeFaces(0)
        HeaderMultiTypeFace = False
    Else
    ...

Surely better to check for single typeface first, thus:

    If HeaderTypeFaces.Length = 1 Then
        cHeaderTypeFace = HeaderTypeFaces(0)
        HeaderMultiTypeFace = False
    Else
        If HeaderTypeFaces.Length <> mNumberOfColumns Then
            ToastMessageShow("Invalid number of columns", False)
            Log("SetHeaderTypeFaces: Invalid number of columns")
            Return
        End If
        cHeaderTypeFaces = HeaderTypeFaces
        HeaderMultiTypeFace = True
    End If

There does not seem to be the same problem with cell typefaces because there are both singular and plural subs.

I'm not actually using distinct typefaces, so I would not consider my usage to be a comprehensive test.

Mike.

did not understand what the problem?

 

[klaus]

Thank you for reporting it.
Amended the code and added the single HeaderTypeFace property, like for the colors.
The first post in the Flexible Table thread has been updated.

 

[mjcoon]

did not understand what the problem?

Sorry I wasn't clear. Fortunately Klaus understood. Mike.