B4A Library [Class] Flexible Table

This thread will be used by Erel, Melamoud and myself to discuss / post new releases of the Table class.

The table class is a flexible UI component that enable scrollable table like UI, with sortable columns, multiselect rows etc

the table is very efficient, maintaining labels only for visible rows

old thread with details : http://www.b4x.com/forum/additional...view-supports-tables-any-size.html#post110901

The class depend on following libraries:
- StringUtils (standard)
- SQL (standard)
- JavaObject (standard)
- B4XCollections (standard)
- ScrollView2D (additional)

List of major features.
1. scrollable table UI
2. sortable columns
3. select a row, cell or multi select rows
4. callback for selection / click a cell / row
5. callback for long click action
6. read / write to CSV file

Current version --> 3.35 Custom View
Current version --> 1.44 Class

Other complementary routines:

Load data with the Remote Database Connector.


EDIT: LucaMs has written a routine to fill a table with a Remote Database Connector query result see post 182.
The routine hasn't been added into the Class for the reasons explained in post 183.
A sample program can be found HERE.

Code:
B4X:
'load data from a RDC Request
'Result = DBResult object got from a RDC request
'AutomaticWidths  True > set the column widths automaticaly
'Written by LucasMs
Public Sub LoadRDCResult(Result As DBResult, AutomaticWidths As Boolean)
    cAutomaticWidths = AutomaticWidths
    NumberOfColumns = Result.Columns.Size
    innerClearAll(NumberOfColumns)

    Dim Headers(NumberOfColumns) As String
    Dim ColumnWidths(NumberOfColumns) As Int
    Dim HeaderWidths(NumberOfColumns) As Int
    Dim DataWidths(NumberOfColumns) As Int
    Dim col, row As Int
    Dim str As String
    For col = 0 To NumberOfColumns - 1
        Headers(col) = Result.Columns.GetKeyAt(col)
        If AutomaticWidths = False Then
            ColumnWidths(col) = 130dip
            HeaderWidths(col) = 130dip
            DataWidths(col) = 130dip
        Else
            HeaderWidths(col) = cvs.MeasureStringWidth(Headers(col), Typeface.DEFAULT, cTextSize) + 8dip + cLineWidth
            DataWidths(col) = 0

            Dim FieldValue As Object
            For row = 0 To Result.Rows.Size - 1
                Dim Record() As Object = Result.Rows.Get(row)
                FieldValue = Record(col)
                If GetType(FieldValue) = "java.lang.String" Then
                    DataWidths(col) = Max(DataWidths(col), cvs.MeasureStringWidth(str, Typeface.DEFAULT, cTextSize) + 8dip + cLineWidth)
                End If
            Next
            ColumnWidths(col) = Max(HeaderWidths(col), DataWidths(col))
        End If
    Next
    SetHeader(Headers)
    SetColumnsWidths(ColumnWidths)

    For Each Record() As Object In Result.Rows
        Dim R(NumberOfColumns) As String
        Dim FieldV As String
        For col = 0 To NumberOfColumns - 1
            FieldV = Record(col)
            R(col) = FieldV
        Next
        AddRow(R)
    Next
End Sub

This is another routine updated by cimperia in post #392 using a Map for the columns and a List for the rows.
B4X:
'load data from a RDC Request
'A RDC request returns a DBResult object, therefore this method
'could be called as is:
'LoadRDCResult(DBResult.Columns, DBResult.Rows, True)
'AutomaticWidths  True > set the column widths automaticaly
'Written by LucasMs
Public Sub LoadRDCResult(Columns As Map, Rows As List, AutomaticWidths As Boolean)
  cAutomaticWidths = AutomaticWidths
  NumberOfColumns = Columns.Size
  innerClearAll(NumberOfColumns)

  Dim Headers(NumberOfColumns) As String
  Dim ColumnWidths(NumberOfColumns) As Int
  Dim HeaderWidths(NumberOfColumns) As Int
  Dim DataWidths(NumberOfColumns) As Int
  Dim col, row As Int
  Dim str As String
  For col = 0 To NumberOfColumns - 1
    Headers(col) = Columns.GetKeyAt(col)
    If AutomaticWidths = False Then
      ColumnWidths(col) = 130dip
      HeaderWidths(col) = 130dip
      DataWidths(col) = 130dip
    Else
      HeaderWidths(col) = cvs.MeasureStringWidth(Headers(col), Typeface.DEFAULT, cTextSize) + 8dip + cLineWidth
      DataWidths(col) = 0

      Dim FieldValue As Object
      For row = 0 To Rows.Size - 1
        Dim Record() As Object = Rows.Get(row)
        FieldValue = Record(col)
       If GetType(FieldValue) = "java.lang.String" Then
         DataWidths(col) = Max(DataWidths(col), cvs.MeasureStringWidth(str, Typeface.DEFAULT, cTextSize) + 8dip + cLineWidth)
       End If
      Next
      ColumnWidths(col) = Max(HeaderWidths(col), DataWidths(col))
    End If
  Next
  SetHeader(Headers)
  SetColumnsWidths(ColumnWidths)

  For Each Record() As Object In Rows
    Dim R(NumberOfColumns) As String
    Dim FieldV As String
    For col = 0 To NumberOfColumns - 1
      FieldV = Record(col)
      R(col) = FieldV
    Next
    AddRow(R)
  Next
End Sub


Load data from a MSMariaDB database.

Another routine for loading data from a MSMariaDB database can be found in post#727.
Thanks to @Magma.

Updates:
EDIT: 2024.04.21 Version 3.35
Replaced the original sorting functions by new ones kindly provided by forum member RB Smissaert.
Amended first scroll scrolling back to 0
Amended Header with transparent color

EDIT: 2024.01.13 Version 3.33
Changed possible values for DataType
TEXT and NUMBER become T, R and I
Amended problem with column colors
Amended problems with SetHeaderColors and SetHeaderTextColors

Version 3.32
Amended Header and HeaderFirst problem in SaveCSVFromTable
Moved If (lblStatusline... from AddRow to ShowRow

Version 3.31
Added SingleLine property for the Designer
Added StatusLineHeight as a property
Added FastScrollLabelMaxChars as a property

EDIT: 2021.06.28 Version 3.30
Added a check for none numeric values for numeric sorting.

EDIT: 2021.06.28 Version 3.29
Amended problem with column colors
Version 3.28
Added NumberOfColumns in the code
Added TopRowIndex method
Version 3.27
Amended MultiSelect EDIT: 2020.09.02 Version 3.26
Amended problem with sort with remove accents
Amended problem with SetRowColorN
Added SetCellAlignmentColN method
Added SetHeaderAlignmentColN method

EDIT: 2020.08.05 Version 3.24
Amended problem with JumpToRowAndSelect not being selected.
Amended error when setting RowHeight before the table initialized

EDIT: 2020.06.19 Version 3.22
Amended error in the insertRowAt routine.

EDIT: 2020.05.25 Version 3.21
Amended bug with TextSize in fixed columns

EDIT: 2020.05.16 Version 3.20
Added fast scroll feature
Version 3.19
Improved automatic width calculation and hidden columns
Version 3.18
Added a check in RemoveRowColorN to ensure that Row is not out of bounds
Added ShowRow event
Amended automatic width calculations
Amended hidden column width problem

EDIT: 2020.04.21 Version 3.17
Amended HeaderHight problem with fixed columns

EDIT: 2020.04.21 Version 3.16
Amended two errors.

EDIT: 2020.04.14 Version 3.14
Added the methods below
- LoadSQLiteDB4(SQLite As SQL, Query As String, AutomaticWidths As Boolean)
loads SQLite data with data type checking
- LoadSQLiteDB5(SQLite As SQL, Query As String, Values() As String, AutomaticWidths As Boolean).
loads SQLite data with data type checking , similar to LoadSQLiteDB4 but for parametrized queries.
- GetColumnDataTypes As String(), returns an Array with the data type for each column.
- GetColumnDataType(Column As Int) As String, returns the data type of the fiven column.
Added the InnerTotalWidth property, read only.
Added multiple first fiexed columns
Added line colors

EDIT: 2020.03.10 Version 3.10
Amended bug reported HERE

EDIT: 2020.03.06 Version 3.09
Amended bug reported HERE.

EDIT: 2020.02.29 Version 3.08
Amended SetHeaderTypefaces method problem reprted HERE.
Added HeaderTypeface property.

EDIT: 2020.01.08 Version 3.07
Amended bug ShowStatisLine = False property bug.
Added MultiSelect property to Designer properties.
You need to open and close the Designer when you use the new version the first time to make the MultiSelect property active.

EDIT: 2019.12.28 Version 3.06
Amened some bugs

EDIT: 2019.12.25 Version 3.05
Added FirstColumnFixed property which allows to fix the first column.
Attention: You need to open and close the Designer to make the new property active.

EDIT: 2019.11.15 Version 3.04
- Added SelectedRowTextColor and SlectedCellTextColor properties
- Added ZeroSelections property, True > when a selected row is pressed it will be unselected False > it remains selected.

EDIT: 2019.11.12 Version 3.03
- Changed JumpToRowAndSelect(Row As Int, Col As Int) to JumpToRowAndSelect(Col As Int, Row As Int)
- Changed LoadSQLiteDB2 signature. Replaced the possible values from "T", "I", "R" to "TEXT", "NUMBER" for coherence with SetColumnDataTypes.
- Added internal sorting bitmaps, avoids loading the image files into the Files folder.
- Added two new properties: SortBitmapWidth and SortBitmapColor.
- Added SetCustomSortingBitmaps method, which allows to use custom bitmaps instead of the internal ones.
Attention: You need to open and close the Designer to make the new properties active.
Attention: You need to invert the parameters in JumpToRowAndSelect.

EDIT: 2019.07.04 Version 3.02
Amended error reported in post #887

EDIT: 2019.06.26 Version 3.01
Amended SingleLine property setting in the code

EDIT: 2019.04.05 Version 3.00
Amended SetColumnColors and SetTextColors
Removed Reflection library dependency

EDIT: 2018.04.11 Version 2.29
Version 2.27
set the two variables sortedCol and sortingDir to Public instaed of Private
added RemoveAccent routine for sorting with accented characters
Version 2.28
Added SetHeaderTypeFaces
Added SortRemoveAccents property
Version 2.29
Added SaveTableToCSV2 with a user defined separator character

EDIT: 2018.04.11 Version 2.26
added LoadSQLiteDB3 method using SQLExec2 instead of SQLExec
The query can include question marks which will be replaced with the values in the array.

EDIT: 2018.03.27 Version 2.25
amended minor errors
added UpdateCell method

EDIT: 2017.11.19 Version 2.22
improved JumpToRowAndSelect scrolls horizontally to the selected column
improved setHeaderHeight
added padding for status bar Label

EDIT: 2017.06.27 Version 2.19
Replaced DoEvents by Sleep(0)
Asked HERE

EDIT: 2017.06.27 Version 2.19
Replaced DoEvents by Sleep(0)
Asked HERE

EDIT: 2017.05.16 Version 2.18
Amended error reported HERE.

EDIT: 2017.03.09 Version 2.17
Amended error reported HERE.

EDIT: 2017.03.09 Version 2.15
Amended error reported here, Event signatures
#Event: CellClick(col As Int, row As Int)
#Event: CellLongClick(col As Int, row As Int)

EDIT: 2016.12.05 Version 2.14
Added NumberOfColumns and NumberOfRows as Public variables.
Amended error reported here.

EDIT: 2016.12.05 Version 2.13
Amended error reported here.
Added NumberOfColumns as a property for the Designer.

EDIT: 2016.07.30 Version 2.10
Amended error with TextAlignment and HeaderTextAlignment reported in post #606

EDIT: 2016.03.15 Version 2.00
Added CustomView support.
This version can be compiled into a library.
Changes between the previous versions and version 2.00
For a Table added in the Designer, this is new
No need to initialize nor add it onto a parent view
'For a Table added in the Designer, this is new
'No need to initialize nor add it onto a parent view

For a Table added in the code:
The Initialize routine has been splittend into two routines.
New:
Initialize (CallBack As Object, EventName As String)
InitializeTable (vNumberOfColumns As Int, cellAlignement As Int, showStatusL As Boolean)

'Example:
Table1.Initialize(Me, "Table1")
Table1.InitializeTable(5, Gravity.CENTER_HORIZONTAL, True)


Old:
Initialize(CallBack As Object, EventName As String, vNumberOfColumns As Int, cellAlignement As Int, showStatusL As Boolean)
Example:
Table1.Initialize(Me, "Table1", 5, Gravity.CENTER_HORIZONTAL, True)

EDIT: 2015.04.29 Version 1.43
As the modifications in LoadSQLiteDB don't work in all cases I went back.
LoadSQLiteDB as in version 1.40
Added LoadSQLiteDB2 where the column data types must be given.

EDIT: 2015.04.26 Version 1.42
Changed he LoadSQLiteDB routine, version 1.41 didn't work as expected.
The final solution was suggested by cimperia HERE.

EDIT: 2015.04.16 Version 1.41
Changed the LoadSQLiteDB routine according to the error reported in the SQL issue thread
and the SQLite Cursor GetString versus GetDouble thread.
The problem appears with numbers bigger than 999999.
I left version 1.40 in case of problems.
I tested it with a few databases, but I am not sure if it works in all cases.

EDIT: 2015.03.05
Amended bugs reported in posts #383 and #386
Added SetAutomaticWidths routine

EDIT: 2015.02.19
Amended the problem alignment reported in post # 378

EDIT: 2015.02.13
Amended the problem of rows not shown reported in post # 371

EDIT: 2015.01.09
Added header aligments

EDIT: 2014.08.14
Added HeaderHeight property
Amended RowColor problem reported in post #260

EDIT: 2014.08.10
Added SortColumn property asked in post #266
Added UseColumnColors ColumnColors and HeaderColors propeties

EDIT: 2014.05.10 Added RowHeight as a property

Screenshot:

1589638570453.png
 

Attachments

  • TableV1_44.zip
    44.8 KB · Views: 2,217
  • 1589638550715.png
    1589638550715.png
    31.8 KB · Views: 1,640
  • TestFastScroll.zip
    50.6 KB · Views: 1,486
  • Table.bas
    152.2 KB · Views: 225
  • TableV3_35.zip
    110 KB · Views: 307
Last edited:

Kanne

Member
Licensed User
Longtime User
I get "ArrayIndexOutOfBoundsException" when pushing "hide column 4" (because default table only has 2 cols ?) but can't test by changing table via "Change Table" because this also get's an out of bound.
Disabling
"Table1.SetCellAlignments(Alignments)"
will load the table but scrolling crashes with
java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.Object java.lang.reflect.Method.invoke(java.lang.Object, java.lang.Object[])' on a null object reference
 

klaus

Expert
Licensed User
Longtime User
How and when do you get this.
It's difficult for me to find out what happens and why without knowing how you get it.
I get "ArrayIndexOutOfBoundsException" when pushing "hide column 4" (because default table only has 2 cols ?)
Which default table are you speaking of?
but can't test by changing table via "Change Table" because this also get's an out of bound.
What is "Change Table" ?
 

Kanne

Member
Licensed User
Longtime User
I'm sorry for not having described it in detail: the new table.bas is running fine in my project, but your example app which you provided crashes by nearly doing anything.
When starting your app I can see two tables (first one with only 2 cols) and a button for hiding col 4 ! Another button labeled "change table" also crashes ...
so I am speaking about your app, not mine ;)
 

martha

Member
If the header's height is changed and a column is fixed, the fixed panel has an incorrect height.

B4X:
Table1.HeaderHeight = nHeight
Table1.NumberOfFixedColumns = 1
 

Attachments

  • table.png
    table.png
    25.9 KB · Views: 195

coldtech

Member
Licensed User
Longtime User
Tried the demo for 3.17 and it threw an exception in this sub routine until I checked if Row was not -1. I was just playing with it and hit the button to see what it did.
If I actually made a selection the error does not occur.

B4X:
'removes the specific color of the given row
Public Sub RemoveRowColorN(Row As Int)
    If Row > 0 Then      
        lstRowColorIndexes.Set(Row, 0)
        If pnlTable.IsInitialized Then
            RefreshLabels
        End If
    End If
End Sub
 

klaus

Expert
Licensed User
Longtime User
Thank you for reporting this.

I should have tested it in the demo program code like this:
B4X:
Sub btnRemoveColor_Click
    If SelectedRow1 > -1 Then
        Table1.UnselectRow(SelectedRow1)
        Table1.RemoveRowColorN(SelectedRow1)
    End If
End Sub

But, I will add a check in the Class code to avoid any trouble for the next update.
 
Last edited:

coldtech

Member
Licensed User
Longtime User
Run the demo and immediately hit the Remove Color button.

** Activity (main) Create, isFirst = true **
** Activity (main) Resume **
Error occurred on line: 2350 (Table)
java.lang.ArrayIndexOutOfBoundsException: length=22; index=-1
at java.util.ArrayList.set(ArrayList.java:455)
 

klaus

Expert
Licensed User
Longtime User
Run the demo and immediately hit the Remove Color button.
That's what I did, and, as written in my previous post, I have added a check in the class code that the row index is not out of bounds for the next update, not yet published.
 

RB Smissaert

Well-Known Member
Licensed User
Longtime User
Yes, I know. If I remember well I looked at your code and it used other modules and I found it complicated to include it in the class.
I was afraid do introduce more bugs than adding a new feature.

I have sorted this now all and changed the sort from being based on a list holding types to an index Quicksort.
This is making it both more simple (less code) and also faster.
Fully tested now (but only on a Samsung S10) and all working fine.

In case somebody is interested this is all the Quicksort code:

B4X:
Sub ReDimPreserveInt(arrInt() As Int, lSize As Int) As Int()
 Dim i As Long
 Dim arrInt2(lSize) As Int
 For i = 0 To arrInt.Length - 1
arrInt2(i) = arrInt(i)
Next

 Return arrInt2
End Sub

Sub QSort1DString_IDX(arrString() As String, _
bAscending As Boolean, _
                      bCompareCaseInsensitive As Boolean) As Int()
 Dim i As Int
Dim j As Int
Dim Lo As Int
Dim Hi As Int
Dim StPtr As Int
Dim HighIndex As Int
Dim strCmp As String
Dim lTmp As Int
Dim arrIndex() As Int

HighIndex = arrString.Length - 1

Dim StLo() As Int
Dim StHi() As Int
 Dim StSize As Int
 If StSize = 0 Then
StSize = 255
Dim StLo(StSize) As Int
Dim StHi(StSize) As Int
 End If
 Dim arrIndex(HighIndex + 1) As Int
 'load the index array
'--------------------
For i = 0 To HighIndex
arrIndex(i) = i
 Next
 StLo(0) = 0
StHi(0) = HighIndex
StPtr = 1

If bAscending Then
  If bCompareCaseInsensitive Then
   Do While StPtr > 0
StPtr = StPtr - 1
Lo = StLo(StPtr)
    Hi = StHi(StPtr)
    'QuickSort
'-----------------
Do While Lo < Hi
i = Lo
     j = Hi
     strCmp = arrString(arrIndex(CInt(Lo + Hi) / 2)).ToLowerCase
     Do  While i <= j
Do While arrString(arrIndex(i)).ToLowerCase.CompareTo(strCmp) < 0
i = i + 1
Loop
Do While arrString(arrIndex(j)).ToLowerCase.CompareTo(strCmp) > 0
j = j - 1
Loop
If i <= j Then
lTmp = arrIndex(i)
arrIndex(i) = arrIndex(j)
arrIndex(j) = lTmp
i = i + 1
j = j - 1
End If 'If i <= j
     Loop
     If j - Lo < Hi - i Then
If i < Hi Then
StLo(StPtr) = i
StHi(StPtr) = Hi
StPtr = StPtr + 1
If StPtr >= StSize Then 'never seen this happen yet
StSize = StSize + StSize
'as B4A doesn't do ReDim Preserve
'--------------------------------
StLo = ReDimPreserveInt(StLo, StSize)
StHi = ReDimPreserveInt(StHi, StSize)
End If
End If
Hi = j
Else 'If j - Lo < Hi - i
If Lo < j Then
StLo(StPtr) = Lo
StHi(StPtr) = j
StPtr = StPtr + 1
If StPtr >= StSize Then 'never seen this happen yet
StSize = StSize + StSize
StLo = ReDimPreserveInt(StLo, StSize)
StHi = ReDimPreserveInt(StHi, StSize)
End If
End If
Lo = i
End If 'If j - Lo < Hi - i
Loop
Loop
Else 'If bCompareCaseInsensitive
Do While StPtr > 0
StPtr = StPtr - 1
Lo = StLo(StPtr)
    Hi = StHi(StPtr)
    Do While Lo < Hi
i = Lo
j = Hi
     strCmp = arrString(CInt(arrIndex((Lo + Hi) / 2)))
     Do While i <= j
Do While arrString(arrIndex(i)).CompareTo(strCmp) < 0
i = i + 1
Loop
Do While arrString(arrIndex(j)).CompareTo(strCmp) > 0
j = j - 1
Loop
If i <= j Then
lTmp = arrIndex(i)
arrIndex(i) = arrIndex(j)
arrIndex(j) = lTmp
i = i + 1
j = j - 1
End If 'If i <= j
     Loop
     If j - Lo < Hi - i Then
If i < Hi Then
StLo(StPtr) = i
StHi(StPtr) = Hi
StPtr = StPtr + 1
If StPtr >= StSize Then 'never seen this happen yet
StSize = StSize + StSize
StLo = ReDimPreserveInt(StLo, StSize)
StHi = ReDimPreserveInt(StHi, StSize)
End If
End If
Hi = j
Else 'If j - Lo < Hi - i
If Lo < j Then
StLo(StPtr) = Lo
StHi(StPtr) = j
StPtr = StPtr + 1
If StPtr >= StSize Then 'never seen this happen yet
StSize = StSize + StSize
StLo = ReDimPreserveInt(StLo, StSize)
StHi = ReDimPreserveInt(StHi, StSize)
End If
End If
Lo = i
End If 'If j - Lo < Hi - i
Loop
Loop
End If 'If bCompareCaseInsensitive
Else 'If bAscending
  If bCompareCaseInsensitive Then
   Do While StPtr > 0
StPtr = StPtr - 1
Lo = StLo(StPtr)
    Hi = StHi(StPtr)
    'QuickSort
'-----------------
Do While Lo < Hi
i = Lo
     j = Hi
     strCmp = arrString(arrIndex(CInt(Lo + Hi) / 2)).ToLowerCase
     Do  While i <= j
Do While arrString(arrIndex(i)).ToLowerCase.CompareTo(strCmp) > 0
i = i + 1
Loop
Do While arrString(arrIndex(j)).ToLowerCase.CompareTo(strCmp) < 0
j = j - 1
Loop
If i <= j Then
lTmp = arrIndex(i)
arrIndex(i) = arrIndex(j)
arrIndex(j) = lTmp
i = i + 1
j = j - 1
End If 'If i <= j
     Loop
     If j - Lo < Hi - i Then
If i < Hi Then
StLo(StPtr) = i
StHi(StPtr) = Hi
StPtr = StPtr + 1
If StPtr >= StSize Then 'never seen this happen yet
StSize = StSize + StSize
'as B4A doesn't do ReDim Preserve
'--------------------------------
StLo = ReDimPreserveInt(StLo, StSize)
StHi = ReDimPreserveInt(StHi, StSize)
End If
End If
Hi = j
Else 'If j - Lo < Hi - i
If Lo < j Then
StLo(StPtr) = Lo
StHi(StPtr) = j
StPtr = StPtr + 1
If StPtr >= StSize Then 'never seen this happen yet
StSize = StSize + StSize
StLo = ReDimPreserveInt(StLo, StSize)
StHi = ReDimPreserveInt(StHi, StSize)
End If
End If
Lo = i
End If 'If j - Lo < Hi - i
Loop
Loop
Else 'If bCompareCaseInsensitive
Do While StPtr > 0
StPtr = StPtr - 1
Lo = StLo(StPtr)
    Hi = StHi(StPtr)
    Do While Lo < Hi
i = Lo
j = Hi
     strCmp = arrString(CInt(arrIndex((Lo + Hi) / 2)))
     Do While i <= j
Do While arrString(arrIndex(i)).CompareTo(strCmp) > 0
i = i + 1
Loop
Do While arrString(arrIndex(j)).CompareTo(strCmp) < 0
j = j - 1
Loop
If i <= j Then
lTmp = arrIndex(i)
arrIndex(i) = arrIndex(j)
arrIndex(j) = lTmp
i = i + 1
j = j - 1
End If 'If i <= j
     Loop
     If j - Lo < Hi - i Then
If i < Hi Then
StLo(StPtr) = i
StHi(StPtr) = Hi
StPtr = StPtr + 1
If StPtr >= StSize Then 'never seen this happen yet
StSize = StSize + StSize
StLo = ReDimPreserveInt(StLo, StSize)
StHi = ReDimPreserveInt(StHi, StSize)
End If
End If
Hi = j
Else 'If j - Lo < Hi - i
If Lo < j Then
StLo(StPtr) = Lo
StHi(StPtr) = j
StPtr = StPtr + 1
If StPtr >= StSize Then 'never seen this happen yet
StSize = StSize + StSize
StLo = ReDimPreserveInt(StLo, StSize)
StHi = ReDimPreserveInt(StHi, StSize)
End If
End If
Lo = i
End If 'If j - Lo < Hi - i
Loop
Loop
End If 'If bCompareCaseInsensitive
 End If    'If bAscending
 Return arrIndex
End Sub

Sub QSort1DInt_IDX(arrInt() As Int, _
       bAscending As Boolean) As Int()
 Dim i As Int
Dim j As Int
Dim Lo As Int
Dim Hi As Int
Dim StPtr As Int
Dim HighIndex As Int
Dim iCmp As Int
Dim lTmp As Int
Dim arrIndex() As Int

HighIndex = arrInt.Length - 1

Dim StLo() As Int
Dim StHi() As Int
 Dim StSize As Int
 If StSize = 0 Then
StSize = 255
Dim StLo(StSize) As Int
Dim StHi(StSize) As Int
 End If
 Dim arrIndex(HighIndex + 1) As Int
 'load the index array
'--------------------
For i = 0 To HighIndex
arrIndex(i) = i
 Next
 StLo(0) = 0
StHi(0) = HighIndex
 StPtr = 1
 If bAscending Then
Do While StPtr > 0
StPtr = StPtr - 1
Lo = StLo(StPtr)
   Hi = StHi(StPtr)
   'QuickSort
'-----------------
Do While Lo < Hi
i = Lo
    j = Hi
    iCmp = arrInt(arrIndex(CInt(Lo + Hi) / 2))
    Do  While i <= j
Do While arrInt(arrIndex(i)) < iCmp
i = i + 1
Loop
Do While arrInt(arrIndex(j)) > iCmp
j = j - 1
Loop
If i <= j Then
lTmp = arrIndex(i)
arrIndex(i) = arrIndex(j)
arrIndex(j) = lTmp
i = i + 1
j = j - 1
End If 'If i <= j
    Loop
    If j - Lo < Hi - i Then
If i < Hi Then
StLo(StPtr) = i
StHi(StPtr) = Hi
StPtr = StPtr + 1
If StPtr >= StSize Then 'never seen this happen yet
StSize = StSize + StSize
'as B4A doesn't do ReDim Preserve
'--------------------------------
StLo = ReDimPreserveInt(StLo, StSize)
StHi = ReDimPreserveInt(StHi, StSize)
End If
End If
Hi = j
Else 'If j - Lo < Hi - i
If Lo < j Then
StLo(StPtr) = Lo
StHi(StPtr) = j
StPtr = StPtr + 1
If StPtr >= StSize Then 'never seen this happen yet
StSize = StSize + StSize
StLo = ReDimPreserveInt(StLo, StSize)
StHi = ReDimPreserveInt(StHi, StSize)
End If
End If
Lo = i
End If 'If j - Lo < Hi - i
Loop
Loop
Else 'If bAscending
Do While StPtr > 0
StPtr = StPtr - 1
Lo = StLo(StPtr)
   Hi = StHi(StPtr)
   'QuickSort
'-----------------
Do While Lo < Hi
i = Lo
    j = Hi
    iCmp = arrInt(arrIndex(CInt(Lo + Hi) / 2))
    Do  While i <= j
Do While arrInt(arrIndex(i)) > iCmp
i = i + 1
Loop
Do While arrInt(arrIndex(j)) < iCmp
j = j - 1
Loop
If i <= j Then
lTmp = arrIndex(i)
arrIndex(i) = arrIndex(j)
arrIndex(j) = lTmp
i = i + 1
j = j - 1
End If 'If i <= j
    Loop
    If j - Lo < Hi - i Then
If i < Hi Then
StLo(StPtr) = i
StHi(StPtr) = Hi
StPtr = StPtr + 1
If StPtr >= StSize Then 'never seen this happen yet
StSize = StSize + StSize
'as B4A doesn't do ReDim Preserve
'--------------------------------
StLo = ReDimPreserveInt(StLo, StSize)
StHi = ReDimPreserveInt(StHi, StSize)
End If
End If
Hi = j
Else 'If j - Lo < Hi - i
If Lo < j Then
StLo(StPtr) = Lo
StHi(StPtr) = j
StPtr = StPtr + 1
If StPtr >= StSize Then 'never seen this happen yet
StSize = StSize + StSize
StLo = ReDimPreserveInt(StLo, StSize)
StHi = ReDimPreserveInt(StHi, StSize)
End If
End If
Lo = i
End If 'If j - Lo < Hi - i
Loop
Loop
 End If 'If bAscending
 Return arrIndex
End Sub

Sub QSort1DDouble_IDX(arrDouble() As Double, _
       bAscending As Boolean) As Int()
 Dim i As Int
Dim j As Int
Dim Lo As Int
Dim Hi As Int
Dim StPtr As Int
Dim HighIndex As Int
Dim dCmp As Double
Dim lTmp As Int
Dim arrIndex() As Int

HighIndex = arrDouble.Length - 1

Dim StLo() As Int
Dim StHi() As Int
 Dim StSize As Int
 If StSize = 0 Then
StSize = 255
Dim StLo(StSize) As Int
Dim StHi(StSize) As Int
 End If
 Dim arrIndex(HighIndex + 1) As Int
 'load the index array
'--------------------
For i = 0 To HighIndex
arrIndex(i) = i
 Next
 StLo(0) = 0
StHi(0) = HighIndex
StPtr = 1

If bAscending Then
Do While StPtr > 0
StPtr = StPtr - 1
Lo = StLo(StPtr)
   Hi = StHi(StPtr)
   'QuickSort
'-----------------
Do While Lo < Hi
i = Lo
    j = Hi
    dCmp = arrDouble(arrIndex(CInt(Lo + Hi) / 2))
    Do  While i <= j
Do While arrDouble(arrIndex(i)) < dCmp
i = i + 1
Loop
Do While arrDouble(arrIndex(j)) > dCmp
j = j - 1
Loop
If i <= j Then
lTmp = arrIndex(i)
arrIndex(i) = arrIndex(j)
arrIndex(j) = lTmp
i = i + 1
j = j - 1
End If 'If i <= j
    Loop
    If j - Lo < Hi - i Then
If i < Hi Then
StLo(StPtr) = i
StHi(StPtr) = Hi
StPtr = StPtr + 1
If StPtr >= StSize Then 'never seen this happen yet
StSize = StSize + StSize
'as B4A doesn't do ReDim Preserve
'--------------------------------
StLo = ReDimPreserveInt(StLo, StSize)
StHi = ReDimPreserveInt(StHi, StSize)
End If
End If
Hi = j
Else 'If j - Lo < Hi - i
If Lo < j Then
StLo(StPtr) = Lo
StHi(StPtr) = j
StPtr = StPtr + 1
If StPtr >= StSize Then 'never seen this happen yet
StSize = StSize + StSize
StLo = ReDimPreserveInt(StLo, StSize)
StHi = ReDimPreserveInt(StHi, StSize)
End If
End If
Lo = i
End If 'If j - Lo < Hi - i
Loop
Loop
Else
Do While StPtr > 0
StPtr = StPtr - 1
Lo = StLo(StPtr)
   Hi = StHi(StPtr)
   'QuickSort
'-----------------
Do While Lo < Hi
i = Lo
    j = Hi
    dCmp = arrDouble(arrIndex(CInt(Lo + Hi) / 2))
    Do  While i <= j
Do While arrDouble(arrIndex(i)) > dCmp
i = i + 1
Loop
Do While arrDouble(arrIndex(j)) < dCmp
j = j - 1
Loop
If i <= j Then
lTmp = arrIndex(i)
arrIndex(i) = arrIndex(j)
arrIndex(j) = lTmp
i = i + 1
j = j - 1
End If 'If i <= j
    Loop
    If j - Lo < Hi - i Then
If i < Hi Then
StLo(StPtr) = i
StHi(StPtr) = Hi
StPtr = StPtr + 1
If StPtr >= StSize Then 'never seen this happen yet
StSize = StSize + StSize
'as B4A doesn't do ReDim Preserve
'--------------------------------
StLo = ReDimPreserveInt(StLo, StSize)
StHi = ReDimPreserveInt(StHi, StSize)
End If
End If
Hi = j
Else 'If j - Lo < Hi - i
If Lo < j Then
StLo(StPtr) = Lo
StHi(StPtr) = j
StPtr = StPtr + 1
If StPtr >= StSize Then 'never seen this happen yet
StSize = StSize + StSize
StLo = ReDimPreserveInt(StLo, StSize)
StHi = ReDimPreserveInt(StHi, StSize)
End If
End If
Lo = i
End If 'If j - Lo < Hi - i
Loop
Loop
 End If
 Return arrIndex
End Sub

RBS
 

klaus

Expert
Licensed User
Longtime User
I had a look at your code.
About 550 lines of code, that's a lot.
What exactly does the function CInt?
I saw in the forum HERE that you use this code:
B4X:
Sub CInt(o As Object) As Int
    Return Floor(o)
End Sub
Is this what you are using?
If Yes, why not using directly Floor(), you are only using integers in the function?

And you use this.
strCmp = arrString(arrIndex(CInt(Lo + Hi) / 2)).ToLowerCase
and sometimes this:
strCmp = arrString(CInt(arrIndex((Lo + Hi) / 2)))
arrIndex(CInt(Lo + Hi) / 2)
versus CInt(arrIndex((Lo + Hi) / 2))
is this really what you need?
 

RB Smissaert

Well-Known Member
Licensed User
Longtime User
I had a look at your code.
About 550 lines of code, that's a lot.
What exactly does the function CInt?
I saw in the forum HERE that you use this code:
B4X:
Sub CInt(o As Object) As Int
    Return Floor(o)
End Sub
Is this what you are using?
If Yes, why not using directly Floor(), you are only using integers in the function?

And you use this.
strCmp = arrString(arrIndex(CInt(Lo + Hi) / 2)).ToLowerCase
and sometimes this:
strCmp = arrString(CInt(arrIndex((Lo + Hi) / 2)))
arrIndex(CInt(Lo + Hi) / 2)
versus CInt(arrIndex((Lo + Hi) / 2))
is this really what you need?

Yes, 550 lines is a lot code, but these are general purpose functions and not really part of the flexible table code.
Also I used these functions for a long time in VBA and VB6 and I know they work well. Just now converted them to
B4A code.

About CInt: Yes, I think you are right there, and don't need the function call. In my VBA/VB6 code I have integer division: \
and B4A doesn't have that, so quickly picked this function. In fact, thinking about it, I may just do normal division as in
B4A I think if you int var = int var / int var you will get an int value in any case, so do away with CInt etc. Will have a look at this and fix it.
Thanks for bringing that up.

RBS
 

RB Smissaert

Well-Known Member
Licensed User
Longtime User
I had a look at your code.
About 550 lines of code, that's a lot.
What exactly does the function CInt?
I saw in the forum HERE that you use this code:
B4X:
Sub CInt(o As Object) As Int
    Return Floor(o)
End Sub
Is this what you are using?
If Yes, why not using directly Floor(), you are only using integers in the function?

And you use this.
strCmp = arrString(arrIndex(CInt(Lo + Hi) / 2)).ToLowerCase
and sometimes this:
strCmp = arrString(CInt(arrIndex((Lo + Hi) / 2)))
arrIndex(CInt(Lo + Hi) / 2)
versus CInt(arrIndex((Lo + Hi) / 2))
is this really what you need?

Had a look at the CInt thing and noticed many weren't doing anything due to the brackets: CInt(Lo + Hi).
Even the ones that were doing something I don't need, so they are all gone from the Quicksorts and this speeded
it all up a bit further.

RBS
 

RB Smissaert

Well-Known Member
Licensed User
Longtime User
I had a look at your code.
About 550 lines of code, that's a lot.
What exactly does the function CInt?
I saw in the forum HERE that you use this code:
B4X:
Sub CInt(o As Object) As Int
    Return Floor(o)
End Sub
Is this what you are using?
If Yes, why not using directly Floor(), you are only using integers in the function?

And you use this.
strCmp = arrString(arrIndex(CInt(Lo + Hi) / 2)).ToLowerCase
and sometimes this:
strCmp = arrString(CInt(arrIndex((Lo + Hi) / 2)))
arrIndex(CInt(Lo + Hi) / 2)
versus CInt(arrIndex((Lo + Hi) / 2))
is this really what you need?

I had a look at doing the Quicksort directly on the ResultSet, saving setting up the sort arrays.
It is slower than the array sort, but it will make the code a bit simpler.

Secondly, of course the Quicksort code can be halved as we don't need to do bAscending True or False.
As this is an index sort we can always sort ascending and reverse the data update if the sort was descending:

B4X:
 If bAscending Then
  For i = 0 To lUB
   Data.Set(i, DataTemp.Get(arrSortIndex(i)))
  Next
 Else
  For i = 0 To lUB
   Data.Set(i, DataTemp.Get(arrSortIndex(lUB - i)))
  Next
 End If

Thirdly, we could keep the index sorts per column (stored in a map, with the column number as key?) so if we
sort the same column again we can reuse that index and save another sort. As this sort is so fast, not sure this is worth it.

RBS
 

Kanne

Member
Licensed User
Longtime User
Hi Klaus,
is it somehow possible to manually set color for single cell, e.g. by something like
B4X:
'JK - Test
Public Sub SetCellColor(Row As Int, Col As Int, Color As Int) 
    Dim lbls() As Label
    lbls = visibleRows.get(Row)
    If lbls = Null Then 
        Log("Row" & Row & " not in visible Rows !")
        Return
    End If
    lbls(Col).TextColor = Color
    visibleRows.Put(Row,lbls)
End Sub

When using this by
B4X:
    For j = 0 To Table1.NumberOfRows-1
        For i = 1 To 5
            Table1.SetCellColor(j,i+1,Colors.Red)
        Next
    Next
I get some cells (maybe cached or at that time visible) updated, but when scrolling the table new cells are in old color.
 
Last edited:

klaus

Expert
Licensed User
Longtime User
is it somehow possible to manually set color for single cell, e.g. by something like
Sorry no.
I know, this has been asked for several times, but this would need to memorize the color for each cell.
The class is based on 'lazy loading', that means that rows are dynamically removed and redrawn depending on the scrolling.
Currently, the content of each cell is memorized, that's normal, but for the colors we would need to 'double' the allowed memory.
And I am afraid that this will slow down the scrolling behaviour, because for each cell update we need to set it's color.
For small sizes, no problem, but for big sizes???
 
Top