Android Code Snippet Testing for working Internet connnection

Some time ago I published a code snippet for testing for a working Internet connection. A user (https://www.b4x.com/android/forum/members/sam_madinah.115755/ ) recently pointed an error case that I had not encountered and I'd like to republish the resulting updated code snippet.

Sub IsOnline As Boolean
    'Requires Phone Library
    Dim p As Phone
    Dim Response, Error As StringBuilder
    Response.Initialize
    Error.Initialize
    Try
        'Ping Google DNS - if you can't reach this you are in serious trouble (or in China)!
        p.Shell("ping -q -c 1 -W 2 8.8.8.8",Null,Response,Error)
        
        If Error.ToString="" Then
            If Response.ToString.Contains("100% packet loss") Then
                Log("Ping ran but no response " &  Response.ToString)
                Return False
            End If
            Return True
        Else
            Return False
        End If
    Catch
        Log("Error pinging Google DNS: "  & Error.ToString)
        Return False
    End Try

End Sub

The missing use case was where the ping started but it returned no packets. (Usually you get an error string)

 

[Erel]

I recommend you to use ShellAsync instead of Shell. Otherwise your app can be frozen and might be killed.

 

[netsistemas]

Maybe your function are best that this, but i show this:

Sub CheckINTERNET As Boolean
    Dim I As ServerSocket 'network library 'ignore
    Dim UnChar As String
    UnChar = Left(  I.GetMyIP,1)
    If I.GetMyWifiIP.StartsWith("127") And IsNumber(UnChar) =False Then
        Return False
    Else

        Return True
    End If

End Sub

 

[Derek Johnson]

Maybe your function are best that this, but i show this:

Sub CheckINTERNET As Boolean
    Dim I As ServerSocket 'network library 'ignore
    Dim UnChar As String
    UnChar = Left(  I.GetMyIP,1)
    If I.GetMyWifiIP.StartsWith("127") And IsNumber(UnChar) =False Then
        Return False
    Else

        Return True
    End If

End Sub

How does this cover the case where the device has a WiFi connection to the router but the router itself has no internet connection?

 

[netsistemas]

That's true. Good appreciation, but in Spain everything is perfect and that never happens.
Your CODE are very best..