Android Question Wait a Javascript value

[max123]

Hi all,

I 've ported this @stevel05 B4J CodeMirror wrapper to B4A
https://www.b4x.com/android/forum/threads/codemirror-wrapper-and-example.125775/#post-785682

Now I need to get values back from Javascript but I've some problems.

Steve in his B4J code implemented itself a Javascript interface on a JavaFX WebView, ExecuteJavaScript command can execute JS and return back an object so it can back with just one call.

'Executes a script in the context of the current page.
Public Sub ExecuteScript(Script As String) As Object
    Return TJO.RunMethod("executeScript",Array As Object(Script))
End Sub

B4J CodeMirrorWrapper to get editor code do this:

'Get the current code editor text code
Public Sub GetCode() As String
    Return ExecuteScript("editor.getValue();")  ' A single call to inject JS and get back return value to B4J calling module that request it (Main or class module)
End Sub

In my code I use WebViewExtras and ExecuteJavascript method do not return values, so I just created a JS function to get a value and then JS call a B4A sub to pass back it.

The problem here is that this require some time and I do not know how to wait a value.
It always return non last value assigned to a global variable (from previous call).

I've even tried to reset it and wait with while loop (not good option, just for test) while the value change, but as expected it enter in an infinite loop.

Even I do not like that require a global variable.

Here my attemp:

'Get the current text on this CodeEditor.
Public Sub GetCode As String
    '    Code = ""  ' Code is a String global variable
    wve.executeJavascript(mWebView, "getValue();")

'    Return wve.executeJavascript(mWebView, "editor.getValue();"  ' This cannot be used because ExecuteJavascript
                                                                ' method return nothing
    Return Code
End Sub

Public Sub codemirrortext(Value As String)  ' Called by JS to return back the value
    Code = Value
    Log(">>> CodeMirror text from JS: " & CRLF & Code)
End Sub

function GetValue() {
  var text = editor.getValue();
  B4A.CallSub('codemirrortext', true, text);
}

I need to do it on a lots of methods (in the wrapper class).

Wait For I think cannot help here because the sub is called by JS and not B4A, right ?

Please can someone help me to know how to do it in an elegant way ?

Thanks

 

[max123]

Mmmmm... don't like this, encode then decode.

In past I've used a comma separated string between JS and B4X and worked well, tried up 10 arguments, but teorically there's no limit, just browser memory I think.

On B4A side just used regex.split to split the array. I've posted it on the forum, I need to search it.

So you intend on B4A side a single callback and use first argument as ID. Not bad idea.

Many thanks for your advices.

 

[stevel05]

In past I've used a comma separated string between JS and B4X

I think there may be some edge cases that could fail depending on the content of the strings, if they are all plain ascii text it shouldn't be an issue.

 

[max123]

Not always are strings, can be Boolean, Int and more, no custom types, maybe null.

This can help, but the main problem remain, that is to get a value without necessary use one global variable for any value passed back. And find a way to get it in the main without necessary use WaitFor.

 

[stevel05]

Not always are strings, can be Boolean, Int and more, no custom types, maybe null

You'll find out what you can and can't pass when you start testing it, and may have to convert some types for them to work.

 

[max123]

Probably a stupid question.... but B4A Object and JS object are compatible ? I think no but not sure, they probably completely different object structure

 

[stevel05]

No not compatible, if I remember correctly you will get at best, a string representation, So a boolean value may be passed as "true" or "false".

 

[max123]

Sub JSCallback(ID As String, Arg1 As String)
  Select ID
    Case "getMyBoolean"
      If Arg1 = "true" Then
        globalBoolean = True
      Else
        globalBoolean = False
      End If
End Sub

Not always is a problem, with threejs I pass B4X color as Int or Colors.MyColor or Color.RGB(r, g, b) and JS works like a charm., so eg I can color a 3D mesh red by passing Colors.Red or Colors.RGB(255, 0, 0). Even booleans worked.

 

[max123]

How to avoid use global variables ?

 

[stevel05]

Why do you need global variables?

 

[max123]

to assign a returnig value and return back to the main that request it:

 

[stevel05]

If you need to act on the values returned, can't you just call the appropriate sub directly?

 

[max123]

I do not know what you mean.
In the main I just need:

Dim Code As String = CodeEditor1.GetCode

without Wait For, as your old work on codemirror, just like I can get a label.Text or EditText.Text I want to get CodeEditor.Text, nothing other.... I've improved your wrapper, now I added more setters and getters, add code folding and syntax error check for some languages, these added new getters and setters not strictly necessary but useful.

So you think I can avoid to use global variables to store returning values in the callback to next pass to the main in the called public sub ? If yes it's good, but how ?

 

[stevel05]

So you'd do something like:

CodeEditor1.GetCode
Wait For Code_Received(Data As String)
Log(Data)

And the callback sub would be something like:

Sub JSCallback(ID As String, Arg1 As String)
  Select ID
    Case "CodeReceived"
      CallSubDelayed2(Main,"Code_Received",Arg1)
End Sub

 

[max123]

Yes, but require to use Wait For in the main:

Wait For CodeReceived(Data As String)

At this point it require to get everything in codemirror, Theme, Language, cursor position, text selection and more....

 

[stevel05]

Yes, it has to wait for the reply.

 

[stevel05]

And it will keep the program flow. How would you know where to pick up the flow if you're assigning the values to a global variable?

 

[max123]

adding a jsRunning global bool variable as @teddybear suggested on post #13 ?

 

[stevel05]

That still uses a wait for and is more complicated. You can use whichever you prefer, I'd prefer the simple version.

 

[max123]

Yes, thanks, I will try it , your solution do not require a boolean flag ?

So no way to remove Wait For in the main, it need because return a ResumableSub

 

[stevel05]

In my version it is not a resumable sub per se as there is no return value, the wait is for a call from a different sub.