Android Question Best way to delete items from a list using a for loop

[andymc]

If I am using a For next loop to cycle through a list, what's the best way to remove items from the list without having to exit the loop?

I generally do something like:
for x = 0 to myList.length - 1
myobject = mylist.get(x)
if myobject.value1 = 1 then
mylist.removeat(x)
exit
end if
next

 

[Erel]

Please use [ code ] [ /code ] tags (without spaces) when posting code.

Why do you need to exit the loop?

Dim x As Int = 0
Do While x < myList.Length
myobject = mylist.get(x)
  if myobject.value1 = 1 then
   mylist.removeat(x)
Else
  x = x + 1
End If
Loop

 

[andymc]

Thanks Erel. I'm being a noob!

I need to really tidy up my space invaders game code, right now it's written just as I go without any real thoughts to optimisation, memory use or elegant code.
So now it's tidy up time!

 

[bparent]

Please use [ code ] [ /code ] tags (without spaces) when posting code.

Why do you need to exit the loop?

Dim x As Int = 0
Do While x < myList.Length
myobject = mylist.get(x)
  if myobject.value1 = 1 then
   mylist.removeat(x)
Else
  x = x + 1
End If
Loop

Erel,,

Hello, thanks for your great products. I know this is a very old message, but I don't understand the code. I cannot find where a list has a Length property and myobject is not defined and doesn't have a value1 property?

Bernie

 

[Alexander Stolte]

I know this is a very old message

And that's exactly why you should always open a new thread.

I cannot find where a list has a Length property and myobject is not defined and doesn't have a value1 property?

A List type has a "size" property.

 

[derez]

for i =  myList.size - 1 to 0 step -1
    myobject = mylist.get(i)
    if myobject.value1 = 1 then  mylist.removeat(i)
next