Android Question Get name of file from server?

aidymp

Well-Known Member
Licensed User
Longtime User
Hi,

OK so for a while I have been making apps that download files and as long as the link ends in a known extension its pretty reliable. however my users are now using dropbox and tinyurl combinations, I would like to implement it as it makes the users life easy. the question is!!

In most web browsers entering a tinyurl (to a direct file link) the browser will open the save window and show the correct file name!

So far I have always used the URL stripped down to the name and extension this has always worked but with all URL shorteners the file name isn't there! So i don't know the Name or the extension.

Obviously the server is supplying the name to web browsers so how can I read it?

Thanks
 
Sort by date Sort by votes

KMatle

Expert
Licensed User
Longtime User
Are you using php to communicate with your server or is it just a download? I think of safety issues like I never publish real file/foldernames. Do you start a viewer via intent? (f.e. pdf)
 
Upvote 0

aidymp

Well-Known Member
Licensed User
Longtime User
Hi, Sorry I was a little vague! (I have several Download methods in the app, and Im not sure why lol)
I'm using okhttp and a modified hc_ResponseSuccess

B4X: 
Sub hc_ResponseSuccess (Response As OkHttpResponse, TaskId As Int)
    ' ********** Modified code *************
    Dim cs As CountingOutputStream
    'file.openoutput()
    cs.Initialize(File.OpenOutput(TempFolder, TaskId, False))
    Dim j As HttpJob = TaskIdToJob.Get(TaskId)
    Dim Headers As Map=Response.GetHeaders '####################### Added this line
    Response.GetAsynchronously("response", File.OpenOutput(TempFolder, TaskId, False), True, TaskId) '####################### Added this line
    If j.Tag Is JobTag Then
        Dim jt As JobTag = j.Tag
        jt.CountingStream = cs
        jt.Total = Response.ContentLength
        If jt.Data.url = "" Then
            Log("Job cancelled before downloaded started")
            cs.Close
        End If
    End If
    '######################################### Added this and 2 lines above
    Dim i As Int
    For i=0 To Headers.Size-1
    Log(Headers.GetKeyAt(i)&" - "&Headers.GetValueAt(i))
    Next
    '**************************************
End Sub

I was hoping something would say filename! lol but i just get this

keep-alive - [timeout=5, max=82]
last-modified - [Fri, 15 Mar 2019 15:23:04 GMT]
server - [Apache/2.4.7 (Ubuntu)]
accept-ranges - [bytes]
connection - [Keep-Alive]
content-length - [12348]
content-type - [image/png]
date - [Sun, 07 Apr 2019 21:43:17 GMT]
etag - ["303c-584239d758600"]

This is as far as I get!

Thanks

Aidy
 
Last edited:
Upvote 0

DonManfred

Expert
Licensed User
Longtime User
- I´m pretty sure it is a mistake to use a modified hc
- The httpjob has properties to get the Responseobject in JobDone. Incl. headers.

B4X: 
    If job.Success Then
        Dim resp As OkHttpResponse = job.Response
        Dim list1 As List
        list1 = resp.GetHeaders
        For i = 0 To list1.Size - 1
            Log(list1.Get(i))
        Next
    End If
 
Upvote 0

aidymp

Well-Known Member
Licensed User
Longtime User
Ah! the problem seems to stem from the fact I am using the modules and NOT the library Hence the modified hc that was actually suggested by Erel! . I need to use the modules because I need the progress event sub.

So adding @DonManfred 's code gives the error Unknown Member on response in relation to
B4X: 
Dim resp As OkHttpResponse = job.Response

I did try the library version (with no progress event exposed) and that ran ((i didnt check if it did what I wanted) as I really do need the progress event)

UPDATE #############

I started with the modules from https://www.b4x.com/android/forum/threads/download-huge-files-with-httputils2.30220/ with the modified hc

I then realised they where out of date. As there was no .response object!

So moved onto https://www.b4x.com/android/forum/threads/b4x-okhttputils2-ihttputils2-httputils2-source-code.82632/

The code now runs but I get.
httputils2service_hc_responsesuccess (java line: 189)
java.lang.NullPointerException: Attempt to invoke virtual method 'okhttp3.Headers okhttp3.Response.headers()' on a null object reference
at anywheresoftware.b4h.okhttp.OkHttpClientWrapper$OkHttpResponse.GetHeaders(OkHttpClientWrapper.java:572)
at com.radianware.raddl.httputils2service._hc_responsesuccess(httputils2service.java:189)
at java.lang.reflect.Method.invoke(Native Method)
at anywheresoftware.b4a.BA.raiseEvent2(BA.java:196)
at anywheresoftware.b4a.BA$2.run(BA.java:370)
at android.os.Handler.handleCallback(Handler.java:873)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:193)
at android.app.ActivityThread.main(ActivityThread.java:6669)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)

No matter how I try to read the object!

Any tips?

Thanks
 
Last edited:
Upvote 0

aidymp

Well-Known Member
Licensed User
Longtime User
I have updated the .bas modules with the library source v2.70 in the Large file download example and modified the hc, all fine I then added the code suggested by @DonManfred It produces the same error, Does that mean that headers are not given by the server? or there is a bug in my code? the updated large file example is attached to this post and the code you suggested is in the Main module at line 46.
 

Attachments

  • lfd-okhttp2modules.zip
    12.7 KB · Views: 303
Upvote 0

DonManfred

Expert
Licensed User
Longtime User
aidymp said:
Does that mean that headers are not given by the server?
Click to expand...
you are not calling any webapi there. You are accessing the file directly from the server. The server does not send any additional headers.
you already know the name as it is part of the downloadurl. Why not use that name? That´s what a browser will do....
 
Upvote 0

aidymp

Well-Known Member
Licensed User
Longtime User

The whole point of the question is I do not know the filename or type!?

In the original question I asked about getting the file name that my browser produces for urls like http://tinyurl.com/y3lr927 my browser gives the exact file name! similarly https://go.onelink.me/app/1f84795 chrome also produces the correct filename for this.

The above links have been modified to be broken! As im not the file owner.

How do I get the filename from the server?

Thats the question i need answering.

Thanks
 
Upvote 0

DonManfred

Expert
Licensed User
Longtime User
Upvote 0

DonManfred

Expert
Licensed User
Longtime User
aidymp said:
similarly https://go.onelink.me/app/1f84795 chrome also produces the correct filename for this.
Click to expand...

This are the header my browser gets while requestin this URL


Note that the filename is in the URL....

I expect this header to appear in the result. Will try later when @home.
 
Upvote 0

aidymp

Well-Known Member
Licensed User
Longtime User
DonManfred said:
This are the header my browser gets while requestin this URL



Note that the filename is in the URL....

I expect this header to appear in the result. Will try later when @home.
Click to expand...

this is exactly what I require. however I just get a crash...
 
Upvote 0

DonManfred

Expert
Licensed User
Longtime User
B4X: 
    Log($"Download https://go.onelink.me/app/1f84795"$)
    Dim j As HttpJob
    j.Initialize("",Me)
    j.Download("https://go.onelink.me/app/1f84795")
    Wait For (j) JobDone(j As HttpJob)
    If j.Success Then
        Log($"Job.Success = true"$)
        Dim resp As OkHttpResponse = j.Response
        Dim list1 As List
        list1 = resp.GetHeaders
        For i = 0 To list1.Size - 1
            Log(list1.Get(i))
        Next
    Else
        Log($"Job.Success false: ${j.ErrorMessage}"$)
    End If
 
Upvote 0

aidymp

Well-Known Member
Licensed User
Longtime User
DonManfred said:
The problem seems to be the website go.onelink.me resp. their answer to the request.
Click to expand...

the link was edited! (i did say) but then in the editor i only changed the link text not the link! so it actually ends in 4! however the crash still happens my end.

my log

** Activity (main) Create, isFirst = true **
** Activity (main) Resume **
Download https://go.onelink.me/app/1f847954
*** Service (httputils2service) Create ***
** Service (httputils2service) Start **
Job.Success = true
main$ResumableSub_btnDownload_Clickresume (java line: 434)
java.lang.NullPointerException: Attempt to invoke virtual method 'okhttp3.Headers okhttp3.Response.headers()' on a null object reference
at anywheresoftware.b4h.okhttp.OkHttpClientWrapper$OkHttpResponse.GetHeaders(OkHttpClientWrapper.java:572)
at b4a.example.main$ResumableSub_btnDownload_Click.resume(main.java:434)
at anywheresoftware.b4a.BA.checkAndRunWaitForEvent(BA.java:250)
at anywheresoftware.b4a.BA.raiseEvent2(BA.java:190)
at anywheresoftware.b4a.keywords.Common$11.run(Common.java:1179)
at android.os.Handler.handleCallback(Handler.java:873)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:193)
at android.app.ActivityThread.main(ActivityThread.java:6669)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)
java.lang.NullPointerException: Attempt to invoke virtual method 'okhttp3.Headers okhttp3.Response.headers()' on a null object reference
 
Last edited:
Upvote 0

OliverA

Expert
Licensed User
Longtime User
Upvote 0

OliverA

Expert
Licensed User
Longtime User
After changing @DonManfred's code to use a map and using your updated link, I have no issues retrieving the headers of the response (B4A v8.80). The issue now I think is that this is a redirect and the final headers retrieved by OkHttpUtils2 and served to the application do not include the Location header information and no hints of a filename are included.

B4X: 
    Log($"Download https://go.onelink.me/app/1f847954"$)
   Dim j As HttpJob
   j.Initialize("",Me)
   j.Download("https://go.onelink.me/app/1f847954")
   Wait For (j) JobDone(j As HttpJob)
   If j.Success Then
       Log($"Job.Success = true"$)
       Dim resp As OkHttpResponse = j.Response
       Dim list1 As Map
       list1 = resp.GetHeaders
       For Each header As String In list1.Keys
           Log(header & ": " & list1.Get(header))
       Next
   Else
       Log($"Job.Success false: ${j.ErrorMessage}"$)
   End If
 
Upvote 0

OliverA

Expert
Licensed User
Longtime User
I don't think you can do a GetHeaders in hc_responseSuccess. I'm guessing here, but I think the Response object is not fully populated until after this call
B4X: 
Response.GetAsynchronously("response", File.OpenOutput(TempFolder, TaskId, False), True, TaskId) '####################### Added this line
Even if you did the Response.GetHeaders after this call, I still think/guess it would fail, since the async call may not be completed (it is async after all). Therefore you should only access the headers of the Response object outside of the HttpUtils module
 
Upvote 0

aidymp

Well-Known Member
Licensed User
Longtime User
OK i will try the above. Maybe if I can get just the file type that would be enough. But obviously the information is returned somewhere as all web browsers return the correct filename..
 
Upvote 0

OliverA

Expert
Licensed User
Longtime User
If you transplant the hc_ResponceSuccess from the "Download huge files..." link (https://www.b4x.com/android/forum/threads/download-huge-files-with-httputils2.30220/) to the updated source, you just needed to add 1 line to get it current (well, to 2.70 standards, since this is the source available as of this post):
B4X: 
Sub hc_ResponseSuccess (Response As OkHttpResponse, TaskId As Int)
   ' ********** Modified code *************
   Dim cs As CountingOutputStream
   cs.Initialize(File.OpenOutput(TempFolder, TaskId, False))
   Dim j As HttpJob = TaskIdToJob.Get(TaskId)
   Dim jt As JobTag = j.Tag
   jt.CountingStream = cs
   jt.Total = Response.ContentLength
   If jt.Data.url = "" Then
       Log("Job cancelled before downloaded started")
       cs.Close
   End If
   j.Response = Response ' <=================== Brings sub up to 2.70 standard
   Response.GetAsynchronously("response", cs , _
       True, TaskId)
   '**************************************
End Sub
And as before (in the plain 2.70 code), Response.GetAsynchronously is the last call (for a reason). If you absolutely had to access the headers in HttpUtils2Services, then you need to do it in Response_StreamFinish at the earliest (they should be accessible any time after that).
 
Upvote 0
You must log in or register to reply here.

Similar Threads

L
  • Question
Android Question httpjob unable to get the filename
Replies
7
Views
1K
ludogomez
L
  • Question
Android Question Downloading multiple files
Replies
6
Views
1K
JamesGreaves
  • Question
Android Question How to get filename from URI (again)?
Replies
4
Views
4K
fredo
  • Question
Android Question Using FileProvider to upload files but...
Replies
3
Views
1K
Erel
A
  • Question
Android Question Can we get all the files' name which are under a specific folder?
Replies
3
Views
850
DonManfred
Menu
Log in
Register
Cookies are required to use this site. You must accept them to continue using the site. Learn more…